The following document contains the results of FindBugs Report
FindBugs Version is 1.3.9
Threshold is low
Effort is max
| Class | Bugs |
|---|---|
| com.ning.metrics.goodwill.sink.NetezzaSink | 6 |
| com.ning.metrics.goodwill.store.CSVFileStore$1 | 1 |
| com.ning.metrics.goodwill.store.MySQLStore | 5 |
| com.ning.metrics.goodwill.store.MySQLStore$1 | 1 |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method com.ning.metrics.goodwill.sink.NetezzaSink.addType(GoodwillSchema) may fail to clean up java.sql.Statement | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 49 | Medium |
| Method com.ning.metrics.goodwill.sink.NetezzaSink.executeExtraSql(String, int, String, String, String, String, GoodwillSchema) may fail to clean up java.sql.Statement | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 86 | Medium |
| com.ning.metrics.goodwill.sink.NetezzaSink.addType(GoodwillSchema) may fail to close Statement | BAD_PRACTICE | ODR_OPEN_DATABASE_RESOURCE | 49 | Medium |
| com.ning.metrics.goodwill.sink.NetezzaSink.executeExtraSql(String, int, String, String, String, String, GoodwillSchema) may fail to close Statement | BAD_PRACTICE | ODR_OPEN_DATABASE_RESOURCE | 86 | Medium |
| Method com.ning.metrics.goodwill.sink.NetezzaSink.getCreateTableStatement(GoodwillSchema) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 118 | Medium |
| Method com.ning.metrics.goodwill.sink.NetezzaSink.executeExtraSql(String, int, String, String, String, String, GoodwillSchema) passes a nonconstant String to an execute method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 87 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class com.ning.metrics.goodwill.store.CSVFileStore$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 116 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Invocation of toString on java.sql.PreparedStatement.executeBatch() in com.ning.metrics.goodwill.store.MySQLStore.updateType(GoodwillSchema) | CORRECTNESS | DMI_INVOKING_TOSTRING_ON_ARRAY | 165 | Medium |
| Method com.ning.metrics.goodwill.store.MySQLStore.buildGoodwillSchemaList() passes a nonconstant String to an execute method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 237 | Low |
| Method com.ning.metrics.goodwill.store.MySQLStore.updateType(GoodwillSchema) passes a nonconstant String to an execute method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 142 | Low |
| A prepared statement is generated from a nonconstant String at com.ning.metrics.goodwill.store.MySQLStore.deleteType(GoodwillSchema) | SECURITY | SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING | 196 | Low |
| A prepared statement is generated from a nonconstant String at com.ning.metrics.goodwill.store.MySQLStore.updateType(GoodwillSchema) | SECURITY | SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING | 136 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class com.ning.metrics.goodwill.store.MySQLStore$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 86 | Low |
