Checkstyle Results

The following document contains the results of Checkstyle.

Summary

Files	Infos	Warnings	Errors
16	0	0	1022

Files

Files	I	W	E
com/ning/metrics/goodwill/binder/config/GoodwillConfig.java	0	0	101
com/ning/metrics/goodwill/binder/listeners/GoodwillGuiceListener.java	0	0	15
com/ning/metrics/goodwill/binder/modules/GoodwillServicesModule.java	0	0	13
com/ning/metrics/goodwill/binder/modules/GoodwillSinkProvider.java	0	0	26
com/ning/metrics/goodwill/binder/modules/GoodwillStoreProvider.java	0	0	30
com/ning/metrics/goodwill/dao/DAOAccess.java	0	0	9
com/ning/metrics/goodwill/dao/DAOBoneCPAccess.java	0	0	46
com/ning/metrics/goodwill/dao/DAOUtil.java	0	0	52
com/ning/metrics/goodwill/endpoint/Registrar.java	0	0	103
com/ning/metrics/goodwill/endpoint/Sink.java	0	0	38
com/ning/metrics/goodwill/modules/ThriftRegistrar.java	0	0	39
com/ning/metrics/goodwill/sink/GoodwillSink.java	0	0	19
com/ning/metrics/goodwill/sink/NetezzaSink.java	0	0	150
com/ning/metrics/goodwill/store/CSVFileStore.java	0	0	83
com/ning/metrics/goodwill/store/GoodwillStore.java	0	0	52
com/ning/metrics/goodwill/store/MySQLStore.java	0	0	246

Rules

Rules	Violations	Severity
JavadocPackage allowLegacy: `"true"`	8	Error
NewlineAtEndOfFile	4	Error
Translation	0	Error
FileLength	0	Error
FileTabCharacter eachLine: `"true"`	0	Error
RegexpSingleline message: `"Line has trailing spaces."` format: `"\s+$"`	0	Error
JavadocMethod	120	Error
JavadocType	32	Error
JavadocVariable	54	Error
JavadocStyle	48	Error
ConstantName	4	Error
LocalFinalVariableName	0	Error
LocalVariableName	0	Error
MemberName	2	Error
MethodName	0	Error
PackageName	0	Error
ParameterName	12	Error
StaticVariableName	0	Error
TypeName	0	Error
AvoidStarImport	0	Error
IllegalImport	0	Error
RedundantImport	0	Error
UnusedImports	2	Error
LineLength	168	Error
MethodLength	0	Error
ParameterNumber	0	Error
EmptyForIteratorPad	0	Error
MethodParamPad	0	Error
NoWhitespaceAfter	0	Error
NoWhitespaceBefore	0	Error
OperatorWrap	16	Error
ParenPad	0	Error
TypecastParenPad	0	Error
WhitespaceAfter	0	Error
WhitespaceAround	0	Error
ModifierOrder	0	Error
RedundantModifier	56	Error
AvoidNestedBlocks	0	Error
EmptyBlock	0	Error
LeftCurly	140	Error
NeedBraces	0	Error
RightCurly	72	Error
AvoidInlineConditionals	0	Error
DoubleCheckedLocking	0	Error
EmptyStatement	0	Error
EqualsHashCode	0	Error
HiddenField	26	Error
IllegalInstantiation	0	Error
InnerAssignment	0	Error
MagicNumber	44	Error
MissingSwitchDefault	0	Error
RedundantThrows	0	Error
SimplifyBooleanExpression	0	Error
SimplifyBooleanReturn	0	Error
DesignForExtension	60	Error
FinalClass	0	Error
HideUtilityClassConstructor	2	Error
InterfaceIsType	0	Error
VisibilityModifier	6	Error
ArrayTypeStyle	0	Error
FinalParameters	140	Error
TodoComment	6	Error
UpperEll	0	Error

Details

com/ning/metrics/goodwill/binder/config/GoodwillConfig.java

Violation	Message	Line
	Missing package-info.java file.	0
	Missing a Javadoc comment.	23
	'{' should be on the previous line.	24
	Missing a Javadoc comment.	25
	Redundant 'public' modifier.	27
	Missing a Javadoc comment.	29
	Redundant 'public' modifier.	31
	Missing a Javadoc comment.	33
	Redundant 'public' modifier.	35
	Missing a Javadoc comment.	37
	Redundant 'public' modifier.	39
	Missing a Javadoc comment.	41
	Redundant 'public' modifier.	43
	Missing a Javadoc comment.	45
	Redundant 'public' modifier.	47
	Missing a Javadoc comment.	49
	Redundant 'public' modifier.	51
	Missing a Javadoc comment.	53
	Redundant 'public' modifier.	55
	Missing a Javadoc comment.	57
	Redundant 'public' modifier.	59
	Missing a Javadoc comment.	61
	Redundant 'public' modifier.	63
	Missing a Javadoc comment.	65
	Redundant 'public' modifier.	67
	Missing a Javadoc comment.	69
	Redundant 'public' modifier.	71
	First sentence should end with a period.	73
	Redundant 'public' modifier.	80
	Missing a Javadoc comment.	82
	Redundant 'public' modifier.	84
	Missing a Javadoc comment.	86
	Redundant 'public' modifier.	88
	Redundant 'public' modifier.	99
	Missing a Javadoc comment.	101
	Redundant 'public' modifier.	103
	Missing a Javadoc comment.	105
	Redundant 'public' modifier.	107
	Line is longer than 80 characters.	110
	Redundant 'public' modifier.	117
	Missing a Javadoc comment.	119
	Redundant 'public' modifier.	121
	Missing a Javadoc comment.	123
	Redundant 'public' modifier.	125
	Missing a Javadoc comment.	127
	Redundant 'public' modifier.	129
	Missing a Javadoc comment.	131
	Redundant 'public' modifier.	133
	Line is longer than 80 characters.	136
	Missing a Javadoc comment.	139
	Redundant 'public' modifier.	141
	Missing a Javadoc comment.	23
	'{' should be on the previous line.	24
	Missing a Javadoc comment.	25
	Redundant 'public' modifier.	27
	Missing a Javadoc comment.	29
	Redundant 'public' modifier.	31
	Missing a Javadoc comment.	33
	Redundant 'public' modifier.	35
	Missing a Javadoc comment.	37
	Redundant 'public' modifier.	39
	Missing a Javadoc comment.	41
	Redundant 'public' modifier.	43
	Missing a Javadoc comment.	45
	Redundant 'public' modifier.	47
	Missing a Javadoc comment.	49
	Redundant 'public' modifier.	51
	Missing a Javadoc comment.	53
	Redundant 'public' modifier.	55
	Missing a Javadoc comment.	57
	Redundant 'public' modifier.	59
	Missing a Javadoc comment.	61
	Redundant 'public' modifier.	63
	Missing a Javadoc comment.	65
	Redundant 'public' modifier.	67
	Missing a Javadoc comment.	69
	Redundant 'public' modifier.	71
	First sentence should end with a period.	73
	Redundant 'public' modifier.	80
	Missing a Javadoc comment.	82
	Redundant 'public' modifier.	84
	Missing a Javadoc comment.	86
	Redundant 'public' modifier.	88
	Redundant 'public' modifier.	99
	Missing a Javadoc comment.	101
	Redundant 'public' modifier.	103
	Missing a Javadoc comment.	105
	Redundant 'public' modifier.	107
	Line is longer than 80 characters.	110
	Redundant 'public' modifier.	117
	Missing a Javadoc comment.	119
	Redundant 'public' modifier.	121
	Missing a Javadoc comment.	123
	Redundant 'public' modifier.	125
	Missing a Javadoc comment.	127
	Redundant 'public' modifier.	129
	Missing a Javadoc comment.	131
	Redundant 'public' modifier.	133
	Line is longer than 80 characters.	136
	Missing a Javadoc comment.	139
	Redundant 'public' modifier.	141

com/ning/metrics/goodwill/binder/listeners/GoodwillGuiceListener.java

Violation	Message	Line
	Missing package-info.java file.	0
	Unused import - com.ning.jetty.utils.healthchecks.DBIHealthCheck.	5
	Missing a Javadoc comment.	12
	'{' should be on the previous line.	13
	Method 'contextInitialized' is not designed for extension - needs to be abstract, final or empty.	14
	Parameter event should be final.	15
	'{' should be on the previous line.	16
	Line is longer than 80 characters.	20
	Unused import - com.ning.jetty.utils.healthchecks.DBIHealthCheck.	5
	Missing a Javadoc comment.	12
	'{' should be on the previous line.	13
	Method 'contextInitialized' is not designed for extension - needs to be abstract, final or empty.	14
	Parameter event should be final.	15
	'{' should be on the previous line.	16
	Line is longer than 80 characters.	20

com/ning/metrics/goodwill/binder/modules/GoodwillServicesModule.java

Violation	Message	Line
	Missing package-info.java file.	0
	Missing a Javadoc comment.	25
	'{' should be on the previous line.	26
	Method 'configure' is not designed for extension - needs to be abstract, final or empty.	27
	'{' should be on the previous line.	29
	Line is longer than 80 characters.	32
	Line is longer than 80 characters.	33
	Missing a Javadoc comment.	25
	'{' should be on the previous line.	26
	Method 'configure' is not designed for extension - needs to be abstract, final or empty.	27
	'{' should be on the previous line.	29
	Line is longer than 80 characters.	32
	Line is longer than 80 characters.	33

com/ning/metrics/goodwill/binder/modules/GoodwillSinkProvider.java

Violation	Message	Line
	Missing a Javadoc comment.	10
	'{' should be on the previous line.	11
	Line is longer than 80 characters.	12
	Missing a Javadoc comment.	12
	Name 'log' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	12
	Missing a Javadoc comment.	14
	Missing a Javadoc comment.	16
	'config' hides a field.	17
	'{' should be on the previous line.	18
	Method 'get' is not designed for extension - needs to be abstract, final or empty.	22
	'{' should be on the previous line.	24
	'}' should be on the same line.	28
	'}' should be on the same line.	32
	Missing a Javadoc comment.	10
	'{' should be on the previous line.	11
	Line is longer than 80 characters.	12
	Missing a Javadoc comment.	12
	Name 'log' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	12
	Missing a Javadoc comment.	14
	Missing a Javadoc comment.	16
	'config' hides a field.	17
	'{' should be on the previous line.	18
	Method 'get' is not designed for extension - needs to be abstract, final or empty.	22
	'{' should be on the previous line.	24
	'}' should be on the same line.	28
	'}' should be on the same line.	32

com/ning/metrics/goodwill/binder/modules/GoodwillStoreProvider.java

Violation	Message	Line
	Missing a Javadoc comment.	15
	'{' should be on the previous line.	16
	Line is longer than 80 characters.	17
	Missing a Javadoc comment.	17
	Name 'log' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	17
	Missing a Javadoc comment.	19
	Missing a Javadoc comment.	21
	'config' hides a field.	22
	'{' should be on the previous line.	23
	Method 'get' is not designed for extension - needs to be abstract, final or empty.	27
	'{' should be on the previous line.	29
	'}' should be on the same line.	35
	'}' should be on the same line.	39
	'}' should be on the same line.	44
	'}' should be on the same line.	48
	Missing a Javadoc comment.	15
	'{' should be on the previous line.	16
	Line is longer than 80 characters.	17
	Missing a Javadoc comment.	17
	Name 'log' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.	17
	Missing a Javadoc comment.	19
	Missing a Javadoc comment.	21
	'config' hides a field.	22
	'{' should be on the previous line.	23
	Method 'get' is not designed for extension - needs to be abstract, final or empty.	27
	'{' should be on the previous line.	29
	'}' should be on the same line.	35
	'}' should be on the same line.	39
	'}' should be on the same line.	44
	'}' should be on the same line.	48

com/ning/metrics/goodwill/dao/DAOAccess.java

Violation	Message	Line
	Missing package-info.java file.	0
	Missing a Javadoc comment.	5
	'{' should be on the previous line.	6
	Missing a Javadoc comment.	7
	Redundant 'public' modifier.	7
	Missing a Javadoc comment.	5
	'{' should be on the previous line.	6
	Missing a Javadoc comment.	7
	Redundant 'public' modifier.	7

com/ning/metrics/goodwill/dao/DAOBoneCPAccess.java

Violation	Message	Line
	Missing a Javadoc comment.	11
	'{' should be on the previous line.	13
	Missing a Javadoc comment.	14
	Missing a Javadoc comment.	16
	Parameter config should be final.	18
	'{' should be on the previous line.	20
	Line is longer than 80 characters.	21
	Missing a Javadoc comment.	25
	Parameter DBHost should be final.	25
	Name 'DBHost' must match pattern '^[a-z][a-zA-Z0-9]*$'.	25
	Parameter DBPort should be final.	26
	Name 'DBPort' must match pattern '^[a-z][a-zA-Z0-9]*$'.	26
	Parameter DBName should be final.	27
	Name 'DBName' must match pattern '^[a-z][a-zA-Z0-9]*$'.	27
	Parameter DBUsername should be final.	28
	Name 'DBUsername' must match pattern '^[a-z][a-zA-Z0-9]*$'.	28
	Parameter DBPassword should be final.	29
	Name 'DBPassword' must match pattern '^[a-z][a-zA-Z0-9]*$'.	29
	'{' should be on the previous line.	30
	Line is longer than 80 characters.	33
	'10' is a magic number.	37
	Method 'getDataSource' is not designed for extension - needs to be abstract, final or empty.	43
	'{' should be on the previous line.	45
	Missing a Javadoc comment.	11
	'{' should be on the previous line.	13
	Missing a Javadoc comment.	14
	Missing a Javadoc comment.	16
	Parameter config should be final.	18
	'{' should be on the previous line.	20
	Line is longer than 80 characters.	21
	Missing a Javadoc comment.	25
	Parameter DBHost should be final.	25
	Name 'DBHost' must match pattern '^[a-z][a-zA-Z0-9]*$'.	25
	Parameter DBPort should be final.	26
	Name 'DBPort' must match pattern '^[a-z][a-zA-Z0-9]*$'.	26
	Parameter DBName should be final.	27
	Name 'DBName' must match pattern '^[a-z][a-zA-Z0-9]*$'.	27
	Parameter DBUsername should be final.	28
	Name 'DBUsername' must match pattern '^[a-z][a-zA-Z0-9]*$'.	28
	Parameter DBPassword should be final.	29
	Name 'DBPassword' must match pattern '^[a-z][a-zA-Z0-9]*$'.	29
	'{' should be on the previous line.	30
	Line is longer than 80 characters.	33
	'10' is a magic number.	37
	Method 'getDataSource' is not designed for extension - needs to be abstract, final or empty.	43
	'{' should be on the previous line.	45

com/ning/metrics/goodwill/dao/DAOUtil.java

Violation	Message	Line
	Missing a Javadoc comment.	12
	Utility classes should not have a public or default constructor.	12
	'{' should be on the previous line.	13
	Missing a Javadoc comment.	14
	First sentence should end with a period.	16
	Parameter connection should be final.	21
	'{' should be on the previous line.	22
	'}' should be on the same line.	26
	Line is longer than 80 characters.	28
	First sentence should end with a period.	33
	Parameter statement should be final.	38
	'{' should be on the previous line.	39
	'}' should be on the same line.	43
	Line is longer than 80 characters.	45
	Parameter resultSet should be final.	55
	'{' should be on the previous line.	56
	'}' should be on the same line.	60
	Line is longer than 80 characters.	62
	Parameter connection should be final.	73
	Parameter statement should be final.	73
	'{' should be on the previous line.	74
	First sentence should end with a period.	79
	Line is longer than 80 characters.	86
	Parameter connection should be final.	86
	Parameter statement should be final.	86
	Parameter resultSet should be final.	86
	Missing a Javadoc comment.	12
	Utility classes should not have a public or default constructor.	12
	'{' should be on the previous line.	13
	Missing a Javadoc comment.	14
	First sentence should end with a period.	16
	Parameter connection should be final.	21
	'{' should be on the previous line.	22
	'}' should be on the same line.	26
	Line is longer than 80 characters.	28
	First sentence should end with a period.	33
	Parameter statement should be final.	38
	'{' should be on the previous line.	39
	'}' should be on the same line.	43
	Line is longer than 80 characters.	45
	Parameter resultSet should be final.	55
	'{' should be on the previous line.	56
	'}' should be on the same line.	60
	Line is longer than 80 characters.	62
	Parameter connection should be final.	73
	Parameter statement should be final.	73
	'{' should be on the previous line.	74
	First sentence should end with a period.	79
	Line is longer than 80 characters.	86
	Parameter connection should be final.	86
	Parameter statement should be final.	86
	Parameter resultSet should be final.	86

com/ning/metrics/goodwill/endpoint/Registrar.java

Violation	Message	Line
	Missing package-info.java file.	0
	Missing a Javadoc comment.	41
	'{' should be on the previous line.	43
	Missing a Javadoc comment.	44
	Missing a Javadoc comment.	46
	Missing a Javadoc comment.	47
	Missing a Javadoc comment.	48
	Missing a Javadoc comment.	50
	Parameter config should be final.	52
	'config' hides a field.	52
	Parameter store should be final.	53
	'store' hides a field.	53
	Parameter sink should be final.	54
	'sink' hides a field.	54
	'{' should be on the previous line.	56
	Method 'getAll' is not designed for extension - needs to be abstract, final or empty.	70
	Missing a Javadoc comment.	70
	'{' should be on the previous line.	73
	Method 'getAllJson' is not designed for extension - needs to be abstract, final or empty.	84
	Missing a Javadoc comment.	84
	'{' should be on the previous line.	87
	Line is longer than 80 characters.	88
	Method 'getTypeJson' is not designed for extension - needs to be abstract, final or empty.	91
	Missing a Javadoc comment.	91
	Line is longer than 80 characters.	94
	Parameter typeName should be final.	94
	Line is longer than 80 characters.	97
	'}' should be on the same line.	98
	Line is longer than 80 characters.	102
	Method 'deleteType' is not designed for extension - needs to be abstract, final or empty.	109
	Missing a Javadoc comment.	109
	Line is longer than 80 characters.	111
	Parameter typeName should be final.	111
	'}' should be on the same line.	119
	'}' should be on the same line.	125
	Line is longer than 80 characters.	127
	'}' should be on the same line.	129
	Method 'post' is not designed for extension - needs to be abstract, final or empty.	138
	Missing a Javadoc comment.	138
	Parameter jsonThriftTypeString should be final.	141
	'{' should be on the previous line.	143
	Line is longer than 80 characters.	147
	'}' should be on the same line.	148
	Line is longer than 80 characters.	150
	Method 'put' is not designed for extension - needs to be abstract, final or empty.	157
	Missing a Javadoc comment.	157
	Parameter jsonThriftTypeString should be final.	160
	'{' should be on the previous line.	162
	Line is longer than 80 characters.	164
	Line is longer than 80 characters.	166
	'}' should be on the same line.	167
	Line is longer than 80 characters.	169
	Missing a Javadoc comment.	41
	'{' should be on the previous line.	43
	Missing a Javadoc comment.	44
	Missing a Javadoc comment.	46
	Missing a Javadoc comment.	47
	Missing a Javadoc comment.	48
	Missing a Javadoc comment.	50
	Parameter config should be final.	52
	'config' hides a field.	52
	Parameter store should be final.	53
	'store' hides a field.	53
	Parameter sink should be final.	54
	'sink' hides a field.	54
	'{' should be on the previous line.	56
	Method 'getAll' is not designed for extension - needs to be abstract, final or empty.	70
	Missing a Javadoc comment.	70
	'{' should be on the previous line.	73
	Method 'getAllJson' is not designed for extension - needs to be abstract, final or empty.	84
	Missing a Javadoc comment.	84
	'{' should be on the previous line.	87
	Line is longer than 80 characters.	88
	Method 'getTypeJson' is not designed for extension - needs to be abstract, final or empty.	91
	Missing a Javadoc comment.	91
	Line is longer than 80 characters.	94
	Parameter typeName should be final.	94
	Line is longer than 80 characters.	97
	'}' should be on the same line.	98
	Line is longer than 80 characters.	102
	Method 'deleteType' is not designed for extension - needs to be abstract, final or empty.	109
	Missing a Javadoc comment.	109
	Line is longer than 80 characters.	111
	Parameter typeName should be final.	111
	'}' should be on the same line.	119
	'}' should be on the same line.	125
	Line is longer than 80 characters.	127
	'}' should be on the same line.	129
	Method 'post' is not designed for extension - needs to be abstract, final or empty.	138
	Missing a Javadoc comment.	138
	Parameter jsonThriftTypeString should be final.	141
	'{' should be on the previous line.	143
	Line is longer than 80 characters.	147
	'}' should be on the same line.	148
	Line is longer than 80 characters.	150
	Method 'put' is not designed for extension - needs to be abstract, final or empty.	157
	Missing a Javadoc comment.	157
	Parameter jsonThriftTypeString should be final.	160
	'{' should be on the previous line.	162
	Line is longer than 80 characters.	164
	Line is longer than 80 characters.	166
	'}' should be on the same line.	167
	Line is longer than 80 characters.	169

com/ning/metrics/goodwill/endpoint/Sink.java

Violation	Message	Line
	File does not end with a newline.	0
	Missing a Javadoc comment.	17
	'{' should be on the previous line.	19
	Missing a Javadoc comment.	20
	Missing a Javadoc comment.	22
	Missing a Javadoc comment.	23
	Missing a Javadoc comment.	25
	Parameter store should be final.	27
	'store' hides a field.	27
	Parameter sink should be final.	28
	'sink' hides a field.	28
	'{' should be on the previous line.	30
	Method 'addTypeToSink' is not designed for extension - needs to be abstract, final or empty.	35
	Missing a Javadoc comment.	35
	Line is longer than 80 characters.	38
	Parameter typeName should be final.	38
	'}' should be on the same line.	46
	Line is longer than 80 characters.	48
	Line is longer than 80 characters.	52
	File does not end with a newline.	0
	Missing a Javadoc comment.	17
	'{' should be on the previous line.	19
	Missing a Javadoc comment.	20
	Missing a Javadoc comment.	22
	Missing a Javadoc comment.	23
	Missing a Javadoc comment.	25
	Parameter store should be final.	27
	'store' hides a field.	27
	Parameter sink should be final.	28
	'sink' hides a field.	28
	'{' should be on the previous line.	30
	Method 'addTypeToSink' is not designed for extension - needs to be abstract, final or empty.	35
	Missing a Javadoc comment.	35
	Line is longer than 80 characters.	38
	Parameter typeName should be final.	38
	'}' should be on the same line.	46
	Line is longer than 80 characters.	48
	Line is longer than 80 characters.	52

com/ning/metrics/goodwill/modules/ThriftRegistrar.java

Violation	Message	Line
	Missing package-info.java file.	0
	Missing a Javadoc comment.	5
	'{' should be on the previous line.	6
	Missing a Javadoc comment.	7
	Missing a Javadoc comment.	8
	Missing a Javadoc comment.	10
	Parameter storeInJSON should be final.	10
	'storeInJSON' hides a field.	10
	'{' should be on the previous line.	11
	Method 'getStoreInJSON' is not designed for extension - needs to be abstract, final or empty.	15
	Missing a Javadoc comment.	15
	'{' should be on the previous line.	16
	Line is longer than 80 characters.	22
	Method 'setActionCoreURL' is not designed for extension - needs to be abstract, final or empty.	28
	Parameter actionCoreURL should be final.	28
	'actionCoreURL' hides a field.	28
	'{' should be on the previous line.	29
	Method 'getActionCoreURL' is not designed for extension - needs to be abstract, final or empty.	33
	Missing a Javadoc comment.	33
	'{' should be on the previous line.	34
	Missing a Javadoc comment.	5
	'{' should be on the previous line.	6
	Missing a Javadoc comment.	7
	Missing a Javadoc comment.	8
	Missing a Javadoc comment.	10
	Parameter storeInJSON should be final.	10
	'storeInJSON' hides a field.	10
	'{' should be on the previous line.	11
	Method 'getStoreInJSON' is not designed for extension - needs to be abstract, final or empty.	15
	Missing a Javadoc comment.	15
	'{' should be on the previous line.	16
	Line is longer than 80 characters.	22
	Method 'setActionCoreURL' is not designed for extension - needs to be abstract, final or empty.	28
	Parameter actionCoreURL should be final.	28
	'actionCoreURL' hides a field.	28
	'{' should be on the previous line.	29
	Method 'getActionCoreURL' is not designed for extension - needs to be abstract, final or empty.	33
	Missing a Javadoc comment.	33
	'{' should be on the previous line.	34

com/ning/metrics/goodwill/sink/GoodwillSink.java

Violation	Message	Line
	File does not end with a newline.	0
	Missing package-info.java file.	0
	Missing a Javadoc comment.	5
	'{' should be on the previous line.	6
	First sentence should end with a period.	7
	Redundant 'public' modifier.	14
	First sentence should end with a period.	16
	Redundant 'public' modifier.	22
	First sentence should end with a period.	24
	Redundant 'public' modifier.	31
	File does not end with a newline.	0
	Missing a Javadoc comment.	5
	'{' should be on the previous line.	6
	First sentence should end with a period.	7
	Redundant 'public' modifier.	14
	First sentence should end with a period.	16
	Redundant 'public' modifier.	22
	First sentence should end with a period.	24
	Redundant 'public' modifier.	31

com/ning/metrics/goodwill/sink/NetezzaSink.java

Violation	Message	Line
	Missing a Javadoc comment.	16
	'{' should be on the previous line.	17
	Missing a Javadoc comment.	18
	Missing a Javadoc comment.	20
	Missing a Javadoc comment.	22
	Parameter config should be final.	24
	'config' hides a field.	24
	'{' should be on the previous line.	26
	Line is longer than 80 characters.	33
	Expected an @return tag.	38
	Method 'addType' is not designed for extension - needs to be abstract, final or empty.	38
	Parameter schema should be final.	39
	Expected @throws tag for 'SQLException'.	40
	Expected @throws tag for 'IOException'.	40
	Expected @throws tag for 'ClassNotFoundException'.	40
	'{' should be on the previous line.	41
	Line is longer than 80 characters.	45
	Line is longer than 80 characters.	46
	Line is longer than 80 characters.	53
	Line is longer than 80 characters.	60
	Line is longer than 80 characters.	61
	Line is longer than 80 characters.	64
	Line is longer than 80 characters.	65
	'}' should be on the same line.	70
	Line is longer than 80 characters.	77
	Missing a Javadoc comment.	77
	Parameter host should be final.	77
	Parameter port should be final.	77
	Parameter database should be final.	77
	Parameter username should be final.	77
	Line is longer than 80 characters.	78
	Parameter password should be final.	78
	Parameter statement should be final.	78
	Parameter schema should be final.	78
	Line is longer than 80 characters.	81
	Line is longer than 80 characters.	85
	'}' should be on the same line.	92
	Line is longer than 80 characters.	94
	'}' should be on the same line.	96
	Line is longer than 80 characters.	98
	Line is longer than 80 characters.	103
	Missing a Javadoc comment.	103
	Parameter statement should be final.	103
	Parameter schema should be final.	103
	Comment matches to-do format 'TODO:'.	105
	Line is longer than 80 characters.	105
	Comment matches to-do format 'TODO:'.	106
	Line is longer than 80 characters.	106
	Missing a Javadoc comment.	112
	Parameter schema should be final.	112
	'{' should be on the previous line.	113
	Line is longer than 80 characters.	118
	Missing a Javadoc comment.	126
	Parameter schema should be final.	126
	'{' should be on the previous line.	127
	Line is longer than 80 characters.	128
	Missing a Javadoc comment.	131
	Parameter name should be final.	131
	'{' should be on the previous line.	132
	Method 'updateType' is not designed for extension - needs to be abstract, final or empty.	144
	Parameter schema should be final.	145
	'{' should be on the previous line.	146
	First sentence should end with a period.	150
	Method 'addTypeInfo' is not designed for extension - needs to be abstract, final or empty.	156
	Parameter schema should be final.	157
	'{' should be on the previous line.	158
	Line is longer than 80 characters.	162
	Line is longer than 80 characters.	165
	Line is longer than 80 characters.	172
	Missing a Javadoc comment.	172
	Parameter host should be final.	172
	Parameter port should be final.	172
	Parameter db should be final.	172
	Parameter username should be final.	172
	Parameter password should be final.	172
	Missing a Javadoc comment.	16
	'{' should be on the previous line.	17
	Missing a Javadoc comment.	18
	Missing a Javadoc comment.	20
	Missing a Javadoc comment.	22
	Parameter config should be final.	24
	'config' hides a field.	24
	'{' should be on the previous line.	26
	Line is longer than 80 characters.	33
	Expected an @return tag.	38
	Method 'addType' is not designed for extension - needs to be abstract, final or empty.	38
	Parameter schema should be final.	39
	Expected @throws tag for 'SQLException'.	40
	Expected @throws tag for 'IOException'.	40
	Expected @throws tag for 'ClassNotFoundException'.	40
	'{' should be on the previous line.	41
	Line is longer than 80 characters.	45
	Line is longer than 80 characters.	46
	Line is longer than 80 characters.	53
	Line is longer than 80 characters.	60
	Line is longer than 80 characters.	61
	Line is longer than 80 characters.	64
	Line is longer than 80 characters.	65
	'}' should be on the same line.	70
	Line is longer than 80 characters.	77
	Missing a Javadoc comment.	77
	Parameter host should be final.	77
	Parameter port should be final.	77
	Parameter database should be final.	77
	Parameter username should be final.	77
	Line is longer than 80 characters.	78
	Parameter password should be final.	78
	Parameter statement should be final.	78
	Parameter schema should be final.	78
	Line is longer than 80 characters.	81
	Line is longer than 80 characters.	85
	'}' should be on the same line.	92
	Line is longer than 80 characters.	94
	'}' should be on the same line.	96
	Line is longer than 80 characters.	98
	Line is longer than 80 characters.	103
	Missing a Javadoc comment.	103
	Parameter statement should be final.	103
	Parameter schema should be final.	103
	Comment matches to-do format 'TODO:'.	105
	Line is longer than 80 characters.	105
	Comment matches to-do format 'TODO:'.	106
	Line is longer than 80 characters.	106
	Missing a Javadoc comment.	112
	Parameter schema should be final.	112
	'{' should be on the previous line.	113
	Line is longer than 80 characters.	118
	Missing a Javadoc comment.	126
	Parameter schema should be final.	126
	'{' should be on the previous line.	127
	Line is longer than 80 characters.	128
	Missing a Javadoc comment.	131
	Parameter name should be final.	131
	'{' should be on the previous line.	132
	Method 'updateType' is not designed for extension - needs to be abstract, final or empty.	144
	Parameter schema should be final.	145
	'{' should be on the previous line.	146
	First sentence should end with a period.	150
	Method 'addTypeInfo' is not designed for extension - needs to be abstract, final or empty.	156
	Parameter schema should be final.	157
	'{' should be on the previous line.	158
	Line is longer than 80 characters.	162
	Line is longer than 80 characters.	165
	Line is longer than 80 characters.	172
	Missing a Javadoc comment.	172
	Parameter host should be final.	172
	Parameter port should be final.	172
	Parameter db should be final.	172
	Parameter username should be final.	172
	Parameter password should be final.	172

com/ning/metrics/goodwill/store/CSVFileStore.java

Violation	Message	Line
	Missing package-info.java file.	0
	Missing a Javadoc comment.	37
	'{' should be on the previous line.	39
	Missing a Javadoc comment.	40
	Missing a Javadoc comment.	42
	Missing a Javadoc comment.	44
	Parameter config should be final.	46
	'{' should be on the previous line.	48
	Method 'parseFile' is not designed for extension - needs to be abstract, final or empty.	53
	Missing a Javadoc comment.	53
	'{' should be on the previous line.	54
	Comment matches to-do format 'TODO:'.	71
	Line is longer than 80 characters.	73
	'}' should be on the same line.	81
	Line is longer than 80 characters.	83
	Line is longer than 80 characters.	88
	'3' is a magic number.	88
	'}' should be on the same line.	89
	Line is longer than 80 characters.	91
	Line is longer than 80 characters.	95
	Line is longer than 80 characters.	97
	Line is longer than 80 characters.	99
	Line is longer than 80 characters.	103
	Method 'getTypes' is not designed for extension - needs to be abstract, final or empty.	109
	'{' should be on the previous line.	111
	Line is longer than 80 characters.	114
	Parameter o should be final.	118
	Parameter o1 should be final.	118
	'{' should be on the previous line.	119
	First sentence should end with a period.	136
	Method 'addType' is not designed for extension - needs to be abstract, final or empty.	141
	Parameter schema should be final.	142
	'{' should be on the previous line.	143
	First sentence should end with a period.	147
	Expected an @return tag.	152
	Method 'updateType' is not designed for extension - needs to be abstract, final or empty.	152
	Parameter schema should be final.	153
	'{' should be on the previous line.	154
	First sentence should end with a period.	159
	Method 'deleteType' is not designed for extension - needs to be abstract, final or empty.	165
	Parameter schema should be final.	166
	'{' should be on the previous line.	167
	Missing a Javadoc comment.	37
	'{' should be on the previous line.	39
	Missing a Javadoc comment.	40
	Missing a Javadoc comment.	42
	Missing a Javadoc comment.	44
	Parameter config should be final.	46
	'{' should be on the previous line.	48
	Method 'parseFile' is not designed for extension - needs to be abstract, final or empty.	53
	Missing a Javadoc comment.	53
	'{' should be on the previous line.	54
	Comment matches to-do format 'TODO:'.	71
	Line is longer than 80 characters.	73
	'}' should be on the same line.	81
	Line is longer than 80 characters.	83
	Line is longer than 80 characters.	88
	'3' is a magic number.	88
	'}' should be on the same line.	89
	Line is longer than 80 characters.	91
	Line is longer than 80 characters.	95
	Line is longer than 80 characters.	97
	Line is longer than 80 characters.	99
	Line is longer than 80 characters.	103
	Method 'getTypes' is not designed for extension - needs to be abstract, final or empty.	109
	'{' should be on the previous line.	111
	Line is longer than 80 characters.	114
	Parameter o should be final.	118
	Parameter o1 should be final.	118
	'{' should be on the previous line.	119
	First sentence should end with a period.	136
	Method 'addType' is not designed for extension - needs to be abstract, final or empty.	141
	Parameter schema should be final.	142
	'{' should be on the previous line.	143
	First sentence should end with a period.	147
	Expected an @return tag.	152
	Method 'updateType' is not designed for extension - needs to be abstract, final or empty.	152
	Parameter schema should be final.	153
	'{' should be on the previous line.	154
	First sentence should end with a period.	159
	Method 'deleteType' is not designed for extension - needs to be abstract, final or empty.	165
	Parameter schema should be final.	166
	'{' should be on the previous line.	167

com/ning/metrics/goodwill/store/GoodwillStore.java

Violation	Message	Line
	Missing a Javadoc comment.	29
	'{' should be on the previous line.	30
	Missing a Javadoc comment.	31
	Missing a Javadoc comment.	33
	Variable 'mapper' must be private and have accessor methods.	33
	Missing a Javadoc comment.	35
	Variable 'sink' must be private and have accessor methods.	35
	Missing a Javadoc comment.	37
	Variable 'goodwillSchemata' must be private and have accessor methods.	37
	First sentence should end with a period.	39
	Method 'findByName' is not designed for extension - needs to be abstract, final or empty.	45
	Parameter typeName should be final.	45
	'{' should be on the previous line.	46
	'}' should be on the same line.	53
	First sentence should end with a period.	61
	Method 'toJSON' is not designed for extension - needs to be abstract, final or empty.	67
	'{' should be on the previous line.	68
	Method 'setSink' is not designed for extension - needs to be abstract, final or empty.	74
	Missing a Javadoc comment.	74
	Parameter sink should be final.	74
	'sink' hides a field.	74
	'{' should be on the previous line.	75
	Missing a Javadoc comment.	79
	First sentence should end with a period.	81
	First sentence should end with a period.	88
	First sentence should end with a period.	96
	Missing a Javadoc comment.	29
	'{' should be on the previous line.	30
	Missing a Javadoc comment.	31
	Missing a Javadoc comment.	33
	Variable 'mapper' must be private and have accessor methods.	33
	Missing a Javadoc comment.	35
	Variable 'sink' must be private and have accessor methods.	35
	Missing a Javadoc comment.	37
	Variable 'goodwillSchemata' must be private and have accessor methods.	37
	First sentence should end with a period.	39
	Method 'findByName' is not designed for extension - needs to be abstract, final or empty.	45
	Parameter typeName should be final.	45
	'{' should be on the previous line.	46
	'}' should be on the same line.	53
	First sentence should end with a period.	61
	Method 'toJSON' is not designed for extension - needs to be abstract, final or empty.	67
	'{' should be on the previous line.	68
	Method 'setSink' is not designed for extension - needs to be abstract, final or empty.	74
	Missing a Javadoc comment.	74
	Parameter sink should be final.	74
	'sink' hides a field.	74
	'{' should be on the previous line.	75
	Missing a Javadoc comment.	79
	First sentence should end with a period.	81
	First sentence should end with a period.	88
	First sentence should end with a period.	96

com/ning/metrics/goodwill/store/MySQLStore.java

Violation	Message	Line
	Missing a Javadoc comment.	41
	'{' should be on the previous line.	42
	Missing a Javadoc comment.	43
	Missing a Javadoc comment.	45
	Name 'TABLE_STRING_DESCRIPTOR' must match pattern '^[a-z][a-zA-Z0-9]*$'.	45
	'+' should be on a new line.	46
	'+' should be on a new line.	47
	'+' should be on a new line.	48
	'+' should be on a new line.	49
	'+' should be on a new line.	50
	'+' should be on a new line.	51
	'+' should be on a new line.	52
	'+' should be on a new line.	53
	Missing a Javadoc comment.	56
	Missing a Javadoc comment.	57
	Missing a Javadoc comment.	59
	Parameter config should be final.	61
	Parameter access should be final.	62
	'access' hides a field.	62
	'{' should be on the previous line.	64
	Missing a Javadoc comment.	68
	Parameter DBTableName should be final.	69
	Name 'DBTableName' must match pattern '^[a-z][a-zA-Z0-9]*$'.	69
	Parameter access should be final.	70
	'access' hides a field.	70
	'{' should be on the previous line.	72
	Method 'getTypes' is not designed for extension - needs to be abstract, final or empty.	79
	'{' should be on the previous line.	81
	Line is longer than 80 characters.	84
	Parameter o should be final.	88
	Parameter o1 should be final.	88
	'{' should be on the previous line.	89
	First sentence should end with a period.	106
	Method 'addType' is not designed for extension - needs to be abstract, final or empty.	111
	Parameter schema should be final.	112
	'{' should be on the previous line.	113
	Line is longer than 80 characters.	114
	First sentence should end with a period.	119
	Expected an @return tag.	124
	Method 'updateType' is not designed for extension - needs to be abstract, final or empty.	124
	Parameter schema should be final.	125
	'{' should be on the previous line.	126
	Line is longer than 80 characters.	141
	Line is longer than 80 characters.	147
	'}' should be on the same line.	148
	'10' is a magic number.	156
	Line is longer than 80 characters.	165
	Line is longer than 80 characters.	166
	'}' should be on the same line.	168
	Line is longer than 80 characters.	170
	'}' should be on the same line.	172
	First sentence should end with a period.	182
	Method 'deleteType' is not designed for extension - needs to be abstract, final or empty.	188
	Parameter schema should be final.	189
	'{' should be on the previous line.	190
	Line is longer than 80 characters.	202
	Line is longer than 80 characters.	207
	Line is longer than 80 characters.	210
	'}' should be on the same line.	214
	Line is longer than 80 characters.	216
	'}' should be on the same line.	218
	Missing a Javadoc comment.	225
	'{' should be on the previous line.	226
	Line is longer than 80 characters.	227
	'7' is a magic number.	243
	'8' is a magic number.	247
	'9' is a magic number.	251
	Line is longer than 80 characters.	258
	'3' is a magic number.	258
	'4' is a magic number.	258
	'5' is a magic number.	258
	'6' is a magic number.	258
	'}' should be on the same line.	259
	Line is longer than 80 characters.	265
	Line is longer than 80 characters.	269
	'}' should be on the same line.	271
	Line is longer than 80 characters.	273
	Line is longer than 80 characters.	275
	Line is longer than 80 characters.	280
	'}' should be on the same line.	283
	Line is longer than 80 characters.	285
	'}' should be on the same line.	286
	Line is longer than 80 characters.	294
	Missing a Javadoc comment.	294
	Parameter statement should be final.	294
	Parameter schema should be final.	294
	Parameter field should be final.	294
	'{' should be on the previous line.	296
	'3' is a magic number.	299
	'4' is a magic number.	300
	'5' is a magic number.	302
	'}' should be on the same line.	303
	'5' is a magic number.	305
	'6' is a magic number.	308
	'}' should be on the same line.	309
	'6' is a magic number.	311
	'7' is a magic number.	314
	'}' should be on the same line.	315
	'7' is a magic number.	317
	'8' is a magic number.	320
	'}' should be on the same line.	321
	'8' is a magic number.	323
	'9' is a magic number.	326
	'}' should be on the same line.	327
	'9' is a magic number.	329
	First sentence should end with a period.	334
	Line is longer than 80 characters.	341
	Parameter schema should be final.	341
	Parameter field should be final.	341
	Line is longer than 80 characters.	343
	First sentence should end with a period.	346
	'{' should be on the previous line.	352
	Line is longer than 80 characters.	353
	First sentence should end with a period.	356
	'{' should be on the previous line.	362
	Line is longer than 80 characters.	363
	First sentence should end with a period.	366
	'{' should be on the previous line.	372
	Line is longer than 80 characters.	373
	First sentence should end with a period.	376
	'{' should be on the previous line.	382
	Missing a Javadoc comment.	386
	'{' should be on the previous line.	387
	Missing a Javadoc comment.	41
	'{' should be on the previous line.	42
	Missing a Javadoc comment.	43
	Missing a Javadoc comment.	45
	Name 'TABLE_STRING_DESCRIPTOR' must match pattern '^[a-z][a-zA-Z0-9]*$'.	45
	'+' should be on a new line.	46
	'+' should be on a new line.	47
	'+' should be on a new line.	48
	'+' should be on a new line.	49
	'+' should be on a new line.	50
	'+' should be on a new line.	51
	'+' should be on a new line.	52
	'+' should be on a new line.	53
	Missing a Javadoc comment.	56
	Missing a Javadoc comment.	57
	Missing a Javadoc comment.	59
	Parameter config should be final.	61
	Parameter access should be final.	62
	'access' hides a field.	62
	'{' should be on the previous line.	64
	Missing a Javadoc comment.	68
	Parameter DBTableName should be final.	69
	Name 'DBTableName' must match pattern '^[a-z][a-zA-Z0-9]*$'.	69
	Parameter access should be final.	70
	'access' hides a field.	70
	'{' should be on the previous line.	72
	Method 'getTypes' is not designed for extension - needs to be abstract, final or empty.	79
	'{' should be on the previous line.	81
	Line is longer than 80 characters.	84
	Parameter o should be final.	88
	Parameter o1 should be final.	88
	'{' should be on the previous line.	89
	First sentence should end with a period.	106
	Method 'addType' is not designed for extension - needs to be abstract, final or empty.	111
	Parameter schema should be final.	112
	'{' should be on the previous line.	113
	Line is longer than 80 characters.	114
	First sentence should end with a period.	119
	Expected an @return tag.	124
	Method 'updateType' is not designed for extension - needs to be abstract, final or empty.	124
	Parameter schema should be final.	125
	'{' should be on the previous line.	126
	Line is longer than 80 characters.	141
	Line is longer than 80 characters.	147
	'}' should be on the same line.	148
	'10' is a magic number.	156
	Line is longer than 80 characters.	165
	Line is longer than 80 characters.	166
	'}' should be on the same line.	168
	Line is longer than 80 characters.	170
	'}' should be on the same line.	172
	First sentence should end with a period.	182
	Method 'deleteType' is not designed for extension - needs to be abstract, final or empty.	188
	Parameter schema should be final.	189
	'{' should be on the previous line.	190
	Line is longer than 80 characters.	202
	Line is longer than 80 characters.	207
	Line is longer than 80 characters.	210
	'}' should be on the same line.	214
	Line is longer than 80 characters.	216
	'}' should be on the same line.	218
	Missing a Javadoc comment.	225
	'{' should be on the previous line.	226
	Line is longer than 80 characters.	227
	'7' is a magic number.	243
	'8' is a magic number.	247
	'9' is a magic number.	251
	Line is longer than 80 characters.	258
	'3' is a magic number.	258
	'4' is a magic number.	258
	'5' is a magic number.	258
	'6' is a magic number.	258
	'}' should be on the same line.	259
	Line is longer than 80 characters.	265
	Line is longer than 80 characters.	269
	'}' should be on the same line.	271
	Line is longer than 80 characters.	273
	Line is longer than 80 characters.	275
	Line is longer than 80 characters.	280
	'}' should be on the same line.	283
	Line is longer than 80 characters.	285
	'}' should be on the same line.	286
	Line is longer than 80 characters.	294
	Missing a Javadoc comment.	294
	Parameter statement should be final.	294
	Parameter schema should be final.	294
	Parameter field should be final.	294
	'{' should be on the previous line.	296
	'3' is a magic number.	299
	'4' is a magic number.	300
	'5' is a magic number.	302
	'}' should be on the same line.	303
	'5' is a magic number.	305
	'6' is a magic number.	308
	'}' should be on the same line.	309
	'6' is a magic number.	311
	'7' is a magic number.	314
	'}' should be on the same line.	315
	'7' is a magic number.	317
	'8' is a magic number.	320
	'}' should be on the same line.	321
	'8' is a magic number.	323
	'9' is a magic number.	326
	'}' should be on the same line.	327
	'9' is a magic number.	329
	First sentence should end with a period.	334
	Line is longer than 80 characters.	341
	Parameter schema should be final.	341
	Parameter field should be final.	341
	Line is longer than 80 characters.	343
	First sentence should end with a period.	346
	'{' should be on the previous line.	352
	Line is longer than 80 characters.	353
	First sentence should end with a period.	356
	'{' should be on the previous line.	362
	Line is longer than 80 characters.	363
	First sentence should end with a period.	366
	'{' should be on the previous line.	372
	Line is longer than 80 characters.	373
	First sentence should end with a period.	376
	'{' should be on the previous line.	382
	Missing a Javadoc comment.	386
	'{' should be on the previous line.	387

Project Documentation

Checkstyle Results

Summary

Files

Rules

Details

com/ning/metrics/goodwill/binder/config/GoodwillConfig.java

com/ning/metrics/goodwill/binder/listeners/GoodwillGuiceListener.java

com/ning/metrics/goodwill/binder/modules/GoodwillServicesModule.java

com/ning/metrics/goodwill/binder/modules/GoodwillSinkProvider.java

com/ning/metrics/goodwill/binder/modules/GoodwillStoreProvider.java

com/ning/metrics/goodwill/dao/DAOAccess.java

com/ning/metrics/goodwill/dao/DAOBoneCPAccess.java

com/ning/metrics/goodwill/dao/DAOUtil.java

com/ning/metrics/goodwill/endpoint/Registrar.java

com/ning/metrics/goodwill/endpoint/Sink.java

com/ning/metrics/goodwill/modules/ThriftRegistrar.java

com/ning/metrics/goodwill/sink/GoodwillSink.java

com/ning/metrics/goodwill/sink/NetezzaSink.java

com/ning/metrics/goodwill/store/CSVFileStore.java

com/ning/metrics/goodwill/store/GoodwillStore.java

com/ning/metrics/goodwill/store/MySQLStore.java